refactor: parallel lint/test jobs and setup-node-workspace composite action#308
Merged
refactor: parallel lint/test jobs and setup-node-workspace composite action#308
Conversation
…node-workspace action
3 tasks
…22 with npm cache
furukama
approved these changes
Apr 14, 2026
Keep the PR's conditional cancel-in-progress (avoid cancelling main branch runs) and the lint/test job split. The contents:write permission from main is already on the test job where the coverage badge is published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unit-testsjob into parallellintandtestjobs — lint is fast and should not block on the slow test suite.github/actions/setup-node-workspacecomposite action encapsulating the 3-step Node setup (setup-node + npm ci + npm run setup), preventing the container dep install from being missed in future jobspublish-release.ymlpublish-npm job to Node 22 with npm cache (absorbs chore: use npm ci in CI and align Node.js version across workflows #300)npm cithroughout CI for lockfile-exact reproducible installsJob graph after this PR
Test plan
lintandtestjobs run in parallel (visible in Actions UI)npm-e2ewaits fortestbefore startingdocker-preflightjobs use the composite action correctlyunit-testsjob remains